Re: OSF build broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Philip Yarra <philip(at)utiba(dot)com>
Cc: Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers(at)postgresql(dot)org, Kurt Roeckx <Q(at)ping(dot)be>
Subject: Re: OSF build broken
Date: 2003-07-07 05:46:21
Message-ID: 13326.1057556781@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Philip Yarra <philip(at)utiba(dot)com> writes:
> And on RedHat 7.3 it's in stdint.h - they must move it around to keep the
> snipers guessing.

Sometimes it seems that way :-(

> What's the best (most portable) way to fix this?

My vote is to rip out every last reference to int64_t and other
system-header-dependent datatypes. These were added in the recent
IPv6 changes, and I thought at the time that they'd not stand the
test of portability, but I kept quiet for lack of evidence. Now
there is some. I recommend sending in a patch that replaces int64_t
with int64, and likewise for anything you don't see defined or used
in src/include/c.h. The stuff in c.h has been through the wars
already, the IPv6 code has not.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-07-07 05:49:48 Re: regressions tests on freebsd/alpha: failure
Previous Message Philip Yarra 2003-07-07 05:29:56 Re: OSF build broken