Re: LIKE <subtable> (second attempt)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Rod Taylor <rbt(at)rbt(dot)ca>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: LIKE <subtable> (second attempt)
Date: 2003-06-23 06:57:02
Message-ID: 200306230657.h5N6v2c14647@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


[ I will use the old patch for the doc changes.]

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Rod Taylor wrote:
-- Start of PGP signed section.
> On Thu, 2003-06-12 at 07:47, Bruce Momjian wrote:
> > Rod, this patch now fails initdb. Can you send over a newer version?
>
> Seems my sql_features.txt update was wrong.
>
> Patch attached. I had a regression failure, but reran make check 10
> times and it hasn't shown up again. I don't think it's related to this
> patch since constraint code hasn't changed with it.
>
>
> *** ./expected/constraints.out Thu Jun 12 15:54:00 2003
> --- ./results/constraints.out Thu Jun 12 16:00:20 2003
> ***************
> *** 107,113 ****
> CONSTRAINT INSERT_CON CHECK (x >= 3 AND y <> 'check failed' AND x <
> 8),
> CHECK (x + z = 0));
> INSERT INTO INSERT_TBL(x,z) VALUES (2, -2);
> ! ERROR: ExecInsert: rejected due to CHECK constraint "insert_con" on
> "insert_tbl"
> SELECT '' AS zero, * FROM INSERT_TBL;
> zero | x | y | z
> ------+---+---+---
> --- 107,113 ----
> CONSTRAINT INSERT_CON CHECK (x >= 3 AND y <> 'check failed' AND x <
> 8),
> CHECK (x + z = 0));
> INSERT INTO INSERT_TBL(x,z) VALUES (2, -2);
> ! ERROR: Relation 134662 does not exist
> SELECT '' AS zero, * FROM INSERT_TBL;
> zero | x | y | z
> ------+---+---+---
>
> ======================================================================
>
>
>
>
> > ---------------------------------------------------------------------------
> >
> > Rod Taylor wrote:
> > -- Start of PGP signed section.
> > > Includes:
> > >
> > > - LIKE <subtable> [ INCLUDING DEFAULTS | EXCLUDING DEFAULTS ]
> > > - Quick cleanup of analyze.c function prototypes.
> > > - New non-reserved keywords (INCLUDING, EXCLUDING, DEFAULTS), SQL 200X
> > >
> > > Opted not to extend for check constraints at this time.
> > >
> > > As per the definition that it's user defined columns, OIDs are NOT
> > > inherited.
> > >
> > > Doc and Source patches attached.
> > >
> > > --
> > > Rod Taylor <rbt(at)rbt(dot)ca>
> > >
> > > PGP Key: http://www.rbt.ca/rbtpub.asc
> >
> > [ Attachment, skipping... ]
> >
> > [ Attachment, skipping... ]
> > -- End of PGP section, PGP failed!
> --
> Rod Taylor <rbt(at)rbt(dot)ca>
>
> PGP Key: http://www.rbt.ca/rbtpub.asc

[ Attachment, skipping... ]
-- End of PGP section, PGP failed!

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Sean Chittenden 2003-06-23 07:14:47 Re: Patch to be verbose about being unable to read ~/.pgpasss...
Previous Message Sean Chittenden 2003-06-23 06:41:16 Small perf fixes/cleanup in src/backend/utils/adt/like.c...