Re: PQescapeBytea on Win32

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zeugswetter Andreas SB SD <ZeugswetterA(at)spardat(dot)at>, Key88 SF <key88sf(at)hotmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PQescapeBytea on Win32
Date: 2003-03-22 18:54:18
Message-ID: 200303221854.h2MIsID29300@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > Tom Lane wrote:
> > >> Doesn't this duplicate a function that we already invented for PQnotify
> > >> structs?
> >
> > > What do you recommend? Do we depricate PQfreeNotify?
> >
> > I dunno. In hindsight it was shortsightedly named. But I don't suppose
> > we want to tell people to use "PQfreeNotify" to free the result of
> > PQescapeBytea ... so deprecation seems to be the order of the day.
> >
> > Do we really want "PQfreemem" either? Maybe it should be "PQfree"?
>
> I am a little concerned that PQfree would be confused with PQclear.
>
> Could we have PQfreeNotify() be a macro to PQfreemem in 7.4?

The only place I see PQfreeNotify() used in our code is libpgtcl, aside
from libpq, and a macro would work fine.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-03-22 19:09:30 Re: PQescapeBytea on Win32
Previous Message Bruce Momjian 2003-03-22 18:49:39 Re: PQescapeBytea on Win32