Re: Cleanup of /contrib

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cleanup of /contrib
Date: 2002-10-18 01:07:54
Message-ID: 200210180107.g9I17sw06346@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I am cleaning up /contrib by adding "autocommit = 'on'" and making it
> > more consistent. Should I be adding this too:
>
> > -- Adjust this setting to control where the objects get created.
> > SET search_path = public;
>
> Yes, that would be a good idea. Without that, the objects might well
> get created in the owning user's private schema; which most of the time
> would be unhelpful. I'm not thrilled with having to edit the script
> if you do happen to want them in a non-public schema, but I have not
> thought of a better approach yet. (Anyone?)
>
> > and doing all object creation in one transaction, like /contrib/cube
> > does?
>
> The one-transaction thing seems unnecessary to me, but if you like it...

Some have it, some don't. I will make it consistent, at least.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-10-18 01:08:55 Re: Current CVS has strange parser for float type
Previous Message Tom Lane 2002-10-18 01:06:35 Re: Cleanup of /contrib