Re: [HACKERS] [PATCH] Win32 native fixes after SSL updates (+more)

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Magnus Naeslund(f) wrote:
> Hello, i noticed that win32 native stopped working/compiling after the SSL merge.
> So i took the opportunity to fix some stuff:
>
> 1. Made the thing compile (typos & needed definitions) with the new pqsecure_* stuff, and added fe-secure.c to the win32.mak makefile.
> 2. Fixed some MULTIBYTE compile errors (when building without MB support).
> 3. Made it do that you can build with debug info: "nmake -f win32.mak DEBUG=1".
> 4. Misc small compiler speedup changes.
>
> The resulting .dll has been tested in production, and everything seems ok.
> I CC:ed -hackers because i'm not sure about two things:
>
> 1. In libpq-int.h I typedef ssize_t as an int because Visual C (v6.0) doesn't define ssize_t. Is that ok, or is there any standard about what type should be used for ssize_t?
>
> 2. To keep the .dll api consistent regarding MULTIBYTE I just return -1 in fe-connect.c:PQsetClientEncoding() instead of taking away the whole function. I wonder if i should do any compares with the conn->client_encoding and return 0 if nothing would have changed (if so how do i check that?).
>
> Regards
>
> Magnus Naeslund
>
> --
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
> Programmer/Networker [|] Magnus Naeslund
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
>
[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026