From: | "Magnus Naeslund(f)" <mag(at)fbab(dot)net> |
---|---|
To: | <pgsql-patches(at)postgresql(dot)org> |
Cc: | <pgsql-hackers(at)postgresql(dot)org> |
Subject: | [PATCH] Win32 native fixes after SSL updates (+more) |
Date: | 2002-07-18 09:41:51 |
Message-ID: | 0ace01c22e3f$580f24c0$f80c0a0a@mnd |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Hello, i noticed that win32 native stopped working/compiling after the SSL merge.
So i took the opportunity to fix some stuff:
1. Made the thing compile (typos & needed definitions) with the new pqsecure_* stuff, and added fe-secure.c to the win32.mak makefile.
2. Fixed some MULTIBYTE compile errors (when building without MB support).
3. Made it do that you can build with debug info: "nmake -f win32.mak DEBUG=1".
4. Misc small compiler speedup changes.
The resulting .dll has been tested in production, and everything seems ok.
I CC:ed -hackers because i'm not sure about two things:
1. In libpq-int.h I typedef ssize_t as an int because Visual C (v6.0) doesn't define ssize_t. Is that ok, or is there any standard about what type should be used for ssize_t?
2. To keep the .dll api consistent regarding MULTIBYTE I just return -1 in fe-connect.c:PQsetClientEncoding() instead of taking away the whole function. I wonder if i should do any compares with the conn->client_encoding and return 0 if nothing would have changed (if so how do i check that?).
Regards
Magnus Naeslund
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Programmer/Networker [|] Magnus Naeslund
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Attachment | Content-Type | Size |
---|---|---|
pgsql_win32.cleanups.1.diff | application/octet-stream | 5.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2002-07-18 13:53:26 | Re: preventing encoding conversion while starting up |
Previous Message | Luis Alberto Amigo Navarro | 2002-07-18 08:18:35 | Re: [HACKERS] why is postgres estimating so badly? |
From | Date | Subject | |
---|---|---|---|
Next Message | Rod Taylor | 2002-07-18 11:36:11 | Re: Between Node |
Previous Message | Bruce Momjian | 2002-07-18 05:00:17 | Re: utils C files |