Re: Use of PG_BINARY_R and "r"

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > My assumption is that text files should use "r" and binary files use
> > PG_BINARY_R.
>
> I believe that's correct. It seems kinda inconsistent though.
>
> > For example, in 7.2 I see pg_hba.conf opened with "r" and pg_ident.conf
> > opened with PG_BINARY_R.
>
> The latter is clearly wrong, since pg_ident.conf is not binary.
>
> Is there any interest in defining
> #define PG_TEXT_R "r"
> #define PG_TEXT_W "w"
> so that AllocateFile is always called with one of this set of macros?
> Or is that just silly?

I kind of like that. The problem I think is that we use "r" in some
places so people assume it is just like ordinary open() args, which it
is unless it is a binary file, where you have to use the macro. That
seems kind of confusing.

However, we don't do this very often so just cleaning up what we have
may be enough.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026