From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pg_dump: use ALTER TABLE for PKs |
Date: | 2002-02-23 02:36:56 |
Message-ID: | 200202230236.g1N2aur06244@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Neil Conway wrote:
> On Mon, 2002-02-18 at 22:46, Peter Eisentraut wrote:
> > Neil Conway writes:
> >
> > > I've attached a patch which enhances pg_dump to use ALTER TABLE when
> > > defining the primary keys of a table (instead of including this
> > > information in the table definition).
> >
> > I think you've got the "7.2 or later" theme in your patch mixed up. The
> > version number you're evaluating is the version of the database you're
> > dumping. The feature you're adding is dependent on the version of the
> > database you're restoring into. The version of the database you're
> > restoring into is always >= the pg_dump version. Thus, you don't need any
> > version checks.
>
> You're absolutely correct -- thanks for spotting that. A new version of
> the patch is attached.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway(at)rogers(dot)com>
> PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-02-23 02:37:31 | Re: questions on ALTER TABLE ... OWNER |
Previous Message | Bruce Momjian | 2002-02-23 02:33:27 | Re: pg_ctl - tighten command parameter checking |