From: | Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pg_dump: use ALTER TABLE for PKs |
Date: | 2002-02-19 04:15:05 |
Message-ID: | 1014092105.372.42.camel@jiro |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 2002-02-18 at 22:46, Peter Eisentraut wrote:
> Neil Conway writes:
>
> > I've attached a patch which enhances pg_dump to use ALTER TABLE when
> > defining the primary keys of a table (instead of including this
> > information in the table definition).
>
> I think you've got the "7.2 or later" theme in your patch mixed up. The
> version number you're evaluating is the version of the database you're
> dumping. The feature you're adding is dependent on the version of the
> database you're restoring into. The version of the database you're
> restoring into is always >= the pg_dump version. Thus, you don't need any
> version checks.
You're absolutely correct -- thanks for spotting that. A new version of
the patch is attached.
Cheers,
Neil
--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC
Attachment | Content-Type | Size |
---|---|---|
pg_dump_pk-2.patch | text/x-patch | 3.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-02-19 05:36:49 | elog() proposals |
Previous Message | Christopher Kings-Lynne | 2002-02-19 03:49:08 | Re: pg_dump: use ALTER TABLE for PKs |