Re: ALTER TABLE RENAME fix

From: Brent Verner <brent(at)rcfile(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: ALTER TABLE RENAME fix
Date: 2001-11-11 09:06:14
Message-ID: 20011111040614.A99927@rcfile.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On 10 Nov 2001 at 23:25 (-0500), Brent Verner wrote:
| On 10 Nov 2001 at 22:42 (-0500), Tom Lane wrote:
| | Brent Verner <brent(at)rcfile(dot)org> writes:
| | > exactly. which is why we've gotta inspecy the relname to determine
| | > which of the attnames to modify.
| |
| | My point is that inspecting the tgfoid is safer, because it
| | unambiguously tells you what you are looking at. The relname is
| | inherently ambiguous because it could be the same on both sides.
|
| gotcha! I'm digging further into how the F_RI_FKEY_* defines
| relate to this case.

Ok, I'm sending an updated patch that does not use relname at all, and
uses an indexscan (getting the Buffer Leak message was fun ;-).

cheers.
brent

--
"Develop your talent, man, and leave the world something. Records are
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing." -- Duane Allman

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Brent Verner 2001-11-11 09:18:44 ALTER TABLE fixes (take two)
Previous Message Brent Verner 2001-11-11 04:25:42 Re: ALTER TABLE RENAME fix