| From: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> |
|---|---|
| To: | peter_e(at)gmx(dot)net |
| Cc: | zakkr(at)zf(dot)jcu(dot)cz, pgman(at)candle(dot)pha(dot)pa(dot)us, barry(at)xythos(dot)com, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: encoding names |
| Date: | 2001-08-23 00:55:06 |
| Message-ID: | 20010823095506U.t-ishii@sra.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
> Tatsuo Ishii writes:
>
> > I don't think you need to change the function name "getdbencoding".
> > "get_canonical_database_encoding" is too long anyway.
>
> But getdbencoding isn't semantically different from the old
> getdatabaseencoding. "encoding" isn't the right term anyway, methinks, it
> should be "character set". So maybe database_character_set()? (No "get"
> please.)
I'm not a native English speaker, so please feel free to choose more
appropriate name.
BTW, what's wrong with "encoding"? I don't think, for example EUC-JP
or utf-8, are character set names.
--
Tatsuo Ishii
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2001-08-23 00:55:56 | Re: libpq.dll & psql.exe on Win32 |
| Previous Message | Tom Lane | 2001-08-23 00:41:22 | Re: GiST patches for 7.2 (please apply) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Karel Zak | 2001-08-23 07:22:36 | Re: encoding names v2. |
| Previous Message | Tatsuo Ishii | 2001-08-23 00:54:53 | Re: encoding names v2. |