From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Marko Kreen <marko(at)l-t(dot)ee> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: encode in base code |
Date: | 2001-07-11 22:14:27 |
Message-ID: | 200107112214.f6BMESk02605@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Thanks. Patch applied. This has the copyright removal and the unsigned
int change.
> On Mon, Jul 02, 2001 at 07:50:45PM +0200, Peter Eisentraut wrote:
> > Marko Kreen writes:
> > > Put encode() into base system. Used part of Alex' patch
> > > for docs, hope he does not mind ;)
> >
> > Please use #include "", not #include <>, for PostgreSQL's header files.
> >
> > Would you mind changing the copyright to match the rest of the source?
> >
> > Put everything in encode.c (not varlena.c), and put encode.c in utils/adt.
> >
> > I think we've covered before that 'uint' is not a standard data type.
> > VARSIZE is of type int32 (signed).
> >
> > To convert from text to C string, use textout().
> >
> > Also, I think the term "encode" is already overloaded for multibyte use.
> > Maybe it needs to be qualified, such as "binary_encode".
>
> Used 'unsigned' in encoding code.
>
> --
> marko
>
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-07-11 22:19:31 | Re: [PATCH] Patch to make pg_hba.conf handle virtualhost access control and samehost keyword |
Previous Message | Mark Volpe | 2001-07-11 22:06:56 | Re: [PATCHES] Re: [PATCH] Re: Setuid functions |