From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp> |
Cc: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, pgsql-hackers(at)postgreSQL(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: [HACKERS] TODO item |
Date: | 2000-02-08 00:07:33 |
Message-ID: | 200002080007.TAA28292@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> > So, I think we are safe if we can either keep that file descriptor open
> > until commit, or re-open it and fsync it on commit. That assume a
> > re-open is hitting the same file. My opinion is that we should just
> > fsync it on close and not worry about a reopen.
> >
>
> I asked about this question 4 months ago but got no answer.
> Obviouly this needs not only md/fd stuff changes but also bufmgr
> changes. Keeping dirtied list of segments of each backend seems
> to work. But I'm afraid of other oversights.
I don't think so. We can just mark file descriptors as needing fsync().
By doing that, we can spin through the buffer cache for each need_fsync
file desciptor, perform any writes needed, and fsync the descriptor.
Seems like little redesign needed, except for adding the need_fsync
flag. Should be no more than about 20 lines.
--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2000-02-08 00:46:30 | Re: [HACKERS] psql and libpq fixes |
Previous Message | Bruce Momjian | 2000-02-08 00:05:33 | Re: [HACKERS] network_ops in 7.0 and pg_dump question |