From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Don Baccus <dhogaza(at)pacifier(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, The Hermit Hacker <scrappy(at)hub(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] LIBPQ patches ... |
Date: | 2000-01-09 18:03:36 |
Message-ID: | 200001091803.NAA20014@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> At 05:27 PM 1/8/00 -0500, Tom Lane wrote:
>
> >I also object strongly to the lack of documentation. Patches that
> >change public APIs and come without doco updates should be rejected
> >out of hand, IMNSHO. Keeping the documentation up to date should
> >not be considered optional --- especially not when you're talking
> >about something that makes subtle and pervasive changes to library
> >behavior.
>
> Boy, Tom's really laid it out in excellent style. If the author of
> such changes doesn't document them, chances are that the documentation
> won't get done. That's very bad.
>
> The automatic rejection of undocumented patches that change the API
> or other user-visible behavior shouldn't be controversial. I know
> there are some folks who aren't native-english speakers, so perhaps
> you don't want to require that the implementor of such patches provide
> the final documentation wording. But the information should be there
> and spelled out in a form that can be very easily moved to the docs.
If it is missing, we get back to them before final release and ask for
doc patches. They get in there one way or another.
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Birch | 2000-01-09 18:45:20 | Re:HEAP_MOVED_IN during vacuum - test case |
Previous Message | Tom Lane | 2000-01-09 16:17:31 | Re: [HACKERS] VACUUM VERBOSE ... |