| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: multithreaded zstd backup compression for client and server |
| Date: | 2022-03-31 12:21:47 |
| Message-ID: | 1febffb3-9b27-e518-3f39-32ac6be4ba56@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/30/22 08:00, Dagfinn Ilmari Mannsåker wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>
>> This patch contains a trivial adjustment to
>> PostgreSQL::Test::Cluster::run_log to make it return a useful value
>> instead of not. I think that should be pulled out and committed
>> independently regardless of what happens to this patch overall, and
>> possibly back-patched.
> run_log() is far from the only such method in PostgreSQL::Test::Cluster.
> Here's a patch that gives the same treatment to all the methods that
> just pass through to the corresponding PostgreSQL::Test::Utils function.
>
> Also attached is a fix a typo in the _get_env doc comment that I noticed
> while auditing the return values.
>
None of these routines in Utils.pm returns a useful value (unlike
run_log()). Typically we don't return the value of Test::More routines.
So -1 on patch 1. I will fix the typo.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-03-31 12:24:46 | Re: Logical replication timeout problem |
| Previous Message | Amit Langote | 2022-03-31 11:11:54 | Re: generic plans and "initial" pruning |