Re: Evaluate arguments of correlated SubPlans in the referencing ExprState

From: Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Evaluate arguments of correlated SubPlans in the referencing ExprState
Date: 2024-07-19 19:19:55
Message-ID: 1eb25f90-fc77-436e-b967-78d465d77a54@yandex.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 18.07.2024 23:01, Tom Lane wrote:
> Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru> writes:
>> I fixed it. The code remains the same.
> I see the cfbot is again complaining that this patch doesn't apply.
>
> In hopes of pushing this over the finish line, I fixed up the (minor)
> patch conflict and also addressed the cosmetic complaints I had
> upthread [1]. I think the attached v4 is committable. If Andres is
> too busy, I can push it, but really it's his patch ...
>
> (BTW, I see no need for additional test cases. Coverage checks show
> that all this code is reached during the core regression tests.)
>
> regards, tom lane
>
> [1] https://www.postgresql.org/message-id/2618533.1677874158%40sss.pgh.pa.us
>
Thank you for your contribution! I looked at the patch again and I agree
that it is ready to be pushed.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-07-19 19:22:57 Re: Wrong results with grouping sets
Previous Message Fujii Masao 2024-07-19 19:16:46 Re: Add privileges test for pg_stat_statements to improve coverage