| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Postgres_fdw join pushdown - wrong results with whole-row reference |
| Date: | 2016-06-27 09:36:01 |
| Message-ID: | 1c4bcedf-1f89-e0b8-0cbf-8811a0858037@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016/06/25 4:14, Robert Haas wrote:
> Committed that way.
Thanks for taking care of this!
I found another bug in error handling of whole-row references in join
pushdown; conversion_error_callback fails to take into account that
get_relid_attribute_name(Oid relid, AttrNumber attnum) can't handle
whole-row references (ie, attnum=0), in which case that would cause
cache lookup errors. Attached is a small patch to address this issue.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| postgres-fdw-conv-error-callback.patch | binary/octet-stream | 702 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2016-06-27 09:56:40 | Re: Postgres_fdw join pushdown - wrong results with whole-row reference |
| Previous Message | Etsuro Fujita | 2016-06-27 09:10:11 | Re: Cleanup in contrib/postgres_fdw/deparse.c |