Re: [HACKERS] PATCH for pgconnection.h

> Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> writes:
> >>
> >> + #ifdef __sun__
> >> + #ifndef __GNUC__
> >> + using namespace std;
> >> + #endif
> >> + #endif

Yes, never applied.

> The above is really, really ugly, not to say broken, because neither
> being on a Sun nor using gcc have anything to do with whether your
> compiler handles namespaces. The problem we are looking at here is that
> the C++ standard is a moving target, and some people have compilers that
> are newer than others.
>
> I think the proper solution is to add a configure-time test to see
> whether a namespace declaration is needed. We could use configure to
> see whether we need ".h" on the end of C++ include file references, too.
> (That's another thing that's going to be site-dependent for a while to
> come.)

I smell TODO list:

* Add configure test to check for C++ need for *.h and namespaces

Added.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026