Re: [HACKERS] GROUP BY fixes committed

> ACCEPTED:
> insert into si_tmpVerifyAccountBalances select invoiceid+3,
> memberid, 1, TotShippingHandling from InvoiceLineDetails
> group by invoiceid+3, memberid;
>
> NOT ACCEPTED:
> insert into si_tmpVerifyAccountBalances select invoiceid+3,
> memberid, 1, TotShippingHandling from InvoiceLineDetails
> group by invoiceid+3, memberid, TotShippingHandling;
>
> Probably error check is including GROUP BY targets in its count of
> things-to-be-inserted :-(. The behavior is quite inconsistent though.
> Also, why doesn't the first example get rejected, since
> TotShippingHandling is neither GROUP BY nor an aggregate??

Yikes. We check to make sure all non-agg columns are referenced in
GROUP BY, but not that all GROUP BY's are in target list, perhaps?

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026