| From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Taral <taral(at)taral(dot)net> |
| Cc: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, hackers(at)postgreSQL(dot)org |
| Subject: | Re: [HACKERS] inet data type regression test fails |
| Date: | 1999-05-10 18:28:22 |
| Message-ID: | 199905101828.OAA04602@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Sun, 9 May 1999, Bruce Momjian wrote:
>
> > > int addr = htonl(ntohl(ip_v4addr(ip)) | (0xffffffff >> ip_bits(ip)));
>
> There needs to be a UL on the end of that constant. Otherwise it depends
> on whether or not the compiler chooses to make it signed or unsigned. Not
> only that, but shifting by >=32 is undefined... Intel chipsets will go mod
> 32 and change 32 to 0.
>
Anyone want to supply a patch?
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 1999-05-10 18:33:54 | Re: [HACKERS] GROUP BY fixes committed |
| Previous Message | Jan Wieck | 1999-05-10 18:27:27 | Re: [HACKERS] numeric & decimal |