From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | darcy(at)druid(dot)net (D'ArcyJ(dot)M(dot)Cain) |
Cc: | darcy(at)druid(dot)net, pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] Syntax errors in current tree |
Date: | 1999-01-18 13:26:40 |
Message-ID: | 199901181326.IAA04004@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> Thus spake Bruce Momjian
> > Fixed. I assume people test the patches before submission, so I don't
>
> Not an unreasonable assumption.
>
> > usually compile after each one. I did add some code in gram.y, and that
> > was what caused the problem.
>
> I don't think that the core maintainers should have to compile each
> and every patch before committing it. However, perhaps a form letter
> can go out to each new submitter asking if their patch was tested and
> holding their first patch till they respond affirmatively. Once they
> have a history, even of one patch, then accept their submissions as
> long as they appear good.
>
> Maybe we need a way to track this. Anyone know of a good system for
> tracking this sort of BASic DATA. :-)
Not really a problem. Most patch problems are either my mucking with it
to merge it with other changes, or platform-specific problems that the
tester would never have see. For example, Win32 used EINTR without
including errno.h.
--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | The Hermit Hacker | 1999-01-18 13:46:01 | Re: [HACKERS] I need a PostgreSQL vacation |
Previous Message | Jose' Soares | 1999-01-18 13:24:41 | about RULES |