| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Don't try to print data type names in slot_store_error_callback( |
| Date: | 2021-07-08 15:21:48 |
| Message-ID: | 1963079.1625757708@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Jul 2, 2021 at 4:05 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The existing code tried to do syscache lookups in an already-failed
>> transaction, which is problematic to say the least.
> Why didn't the assertion in SearchCatCacheInternal() catch this? Was
> this code never actually tested?
It wasn't tested under conditions in which a catalog lookup would
be at real risk of failing --- and I'm not sure that we have any
way to do that mechanically. See discussion downthread about when
a transaction could be considered "failed".
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-07-08 16:28:03 | pgsql: doc: improve PG 14 relnote item about adding btree pages to FSM |
| Previous Message | Robert Haas | 2021-07-08 14:57:22 | Re: pgsql: Don't try to print data type names in slot_store_error_callback( |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-07-08 15:56:10 | Re: refactoring basebackup.c |
| Previous Message | Drouvot, Bertrand | 2021-07-08 15:13:55 | Re: visibility map corruption |