Can we remove SnapshotSelf?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Can we remove SnapshotSelf?
Date: 2005-02-20 22:10:42
Message-ID: 19046.1108937442@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

As of CVS tip, there is no code in the system that uses SnapshotSelf.
I am wondering if we can get rid of it and thereby save one test in
the heavily used HeapTupleSatisfiesVisibility() macro.

There is one place in the foreign-key triggers that uses the underlying
HeapTupleSatisfiesItself() test directly. So it seems possible that we
might someday need SnapshotSelf again as the representation of the
appropriate snapshot test for a foreign-key check. But I suspect that
any future changes in the FK stuff will go in the direction of using
dirty reads instead. In any case we could always put back SnapshotSelf
if we needed it.

Comments?

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message lsunley 2005-02-20 22:49:58 Re: SMP buffer management test question
Previous Message Mark Kirkwood 2005-02-20 20:30:41 Re: Query optimizer 8.0.1 (and 8.0)