Re: Confusing message in log file

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Confusing message in log file
Date: 2008-06-30 23:33:15
Message-ID: 18847.1214868795@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> In any case, this seems a case of stuffing too much in the primary
> message.

Yeah, good point.

> I think it should be something like
> errmsg("parameter \"shared_buffer\" change in configuration file ignored"),
> errdetail("This parameter cannot be changed after server start.")

Seems a bit awkwardly phrased. I propose

errmsg("attempted change to parameter \"shared_buffer\" ignored"),
errdetail("This parameter cannot be changed after server start.")

(or possibly "of" would read better than "to")

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-06-30 23:45:35 Re: Does anything dump per-database config settings? (was Re: ALTER DATABASE vs pg_dump)
Previous Message Andrew Dunstan 2008-06-30 23:29:03 Re: odd output in restore mode