Re: parallel restore fixes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: parallel restore fixes
Date: 2009-03-09 23:42:59
Message-ID: 17972.1236642179@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> + void
> + init_dump_utils()

This should be
> + void
> + init_dump_utils(void)

please. We don't do K&R C around here. I'd lose the added retval
variable too; that's not contributing anything.

> ! #endif;

Semicolon is bogus here.

Looks pretty sane otherwise.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-03-09 23:45:45 Re: Updates of SE-PostgreSQL 8.4devel patches (r1704)
Previous Message Alvaro Herrera 2009-03-09 23:22:54 Re: parallel restore fixes