From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Adding the extension name to EData / log_line_prefix |
Date: | 2024-05-15 15:50:52 |
Message-ID: | 1784552.1715788252@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 14.05.24 01:11, Tom Lane wrote:
>> The mechanism that Andres describes for sourcing the name seems a bit
>> overcomplex though. Why not just allow/require each extension to
>> specify its name as a constant string? We could force the matter by
>> redefining PG_MODULE_MAGIC as taking an argument:
>> PG_MODULE_MAGIC("hstore");
> We kind of already have something like this, for NLS. If you look for
> pg_bindtextdomain(TEXTDOMAIN) and ereport_domain(), this information
> already trickles into the vicinity of the error data. Maybe the same
> thing could just be used for this, by wiring up the macros a bit
> differently.
Hmm, cute idea, but it'd only help for extensions that are
NLS-enabled. Which I bet is a tiny fraction of the population.
So far as I can find, we don't even document how to set up
TEXTDOMAIN for an extension --- you have to cargo-cult the
macro definition from some in-core extension.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2024-05-15 15:52:41 | Re: AIX support |
Previous Message | Robert Haas | 2024-05-15 15:46:34 | Re: CREATE TABLE creates a composite type corresponding to the table row, which is and is not there |