From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Fixup a few 2023 copyright years |
Date: | 2024-05-15 14:30:56 |
Message-ID: | 1773354.1715783456@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Wed, 15 May 2024 at 17:32, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> While running src/tools/copyright.pl, I have noticed that that a
>> newline was missing at the end of index_including.sql, as an effect of
>> the test added by you in a63224be49b8. I've cleaned up that while on
>> it, as it was getting added automatically, and we tend to clean these
>> like in 3f1197191685 or more recently c2df2ed90a82.
> Thanks for fixing that. I'm a little surprised that pgindent does not
> fix that sort of thing.
pgindent does not touch anything but .c and .h files.
I do recommend running "git diff --check" (with --staged if you
already git-added your changes) before you're ready to commit
something. That does find generic whitespace issues, and I
believe it would've found this one.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Jelte Fennema-Nio | 2024-05-15 14:47:27 | Re: Postgres and --config-file option |
Previous Message | Robert Haas | 2024-05-15 14:24:30 | Re: BitmapHeapScan streaming read user and prelim refactoring |