Re: Harmonizing pg_bsd_indent parameter names

Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> On Wed, Jun 12, 2024 at 05:59:14PM -0400, Peter Geoghegan wrote:
>> There is also one oddball case, not quite in either category. This
>> involves zic.c's declaration of
>> link(), when it should actually just be using the #include <unistd.h>
>> declaration.

> That one seems to be synchronized somewhat regularly, and I haven't been
> the one doing the synchronizing, so we might want to be a little more
> cautious there.

Yeah. I'm overdue for another sync with upstream --- I'm dreading
that a little bit because they've been aggressively "modernizing"
their code and I fear it will be painful.

[ ... click click ... git pull ... ] It looks like the way that
reads now in upstream is

#if !HAVE_POSIX_DECLS
extern int getopt(int argc, char * const argv[],
const char * options);
extern int link(const char * target, const char * linkname);
extern char * optarg;
extern int optind;
#endif

We could probably assume that we'll treat their code as though
HAVE_POSIX_DECLS is true and so this whole stanza goes away.
But I'd just as soon not think about it until I have the energy
to do that sync. Unless somebody else is hot to do it (if so,
see the notes at src/timezone/README), let's leave this be
for now.

regards, tom lane