| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Default to hidden visibility for extension libraries where possi |
| Date: | 2022-07-20 14:09:01 |
| Message-ID: | 1697006.1658326141@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Jul 20, 2022 at 9:39 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> ISTM that a comment pointing out that the functions marked PGDLLEXPORT
>> are meant to be externally accessible should be sufficient.
> The name PGDLLEXPORT is actually slightly misleading, now, because
> there's no longer anything about it that is specific to DLLs.
True, but the mess of changing it seems to outweigh any likely clarity
gain. As long as there's adequate commentary about what it means,
I'm okay with the existing naming.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-07-20 14:12:43 | Re: pgsql: Default to hidden visibility for extension libraries where possi |
| Previous Message | Alvaro Herrera | 2022-07-20 14:04:30 | Re: pgsql: Default to hidden visibility for extension libraries where possi |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2022-07-20 14:09:07 | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |
| Previous Message | Alvaro Herrera | 2022-07-20 14:04:30 | Re: pgsql: Default to hidden visibility for extension libraries where possi |