From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Some whitespaces in utility.c |
Date: | 2012-09-04 14:35:07 |
Message-ID: | 16819.1346769307@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Tue, Sep 4, 2012 at 6:57 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> I found some whitespace characters in utility.c introduced by commit
>> 3a0e4d3.
>> Please find attached a patch fixing that which can be applied on postgres
>> master (commit 2f0c7d5).
> That probably exists in many other places in the source as well, but
> it's certainly fairly ugly. So I see nothing wrong cleaning it up whe
> nspotted.
Just as a note: we generally leave it to pgindent to fix this sort of
thing. I'm not sure it's worth the effort of submitting manual patches
for, unless you have reason to think the next pgindent run won't fix it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2012-09-04 14:42:58 | Re: pg_upgrade del/rmdir path fix |
Previous Message | Magnus Hagander | 2012-09-04 13:52:28 | Re: pg_dump incorrect output in plaintext mode |