Re: Removing the fixed-size buffer restriction in hba.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Removing the fixed-size buffer restriction in hba.c
Date: 2023-07-25 00:21:54
Message-ID: 1634790.1690244514@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> I find the choice to keep err_msg in next_token() a bit confusing in
> next_field_expand(). If no errors are possible, why not just get rid
> of it?

Yeah, I dithered about that. I felt like removing it only to put it
back later would be silly, but then again maybe there won't ever be
a need to put it back. I'm OK with removing it if there's not
objections.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2023-07-25 00:25:25 Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"
Previous Message Michael Paquier 2023-07-25 00:14:54 Re: Removing the fixed-size buffer restriction in hba.c