Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c)

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c)
Date: 2024-09-04 18:35:51
Message-ID: 161BDA33-F64B-44B0-8B29-3D17BC888786@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 Sep 2024, at 19:30, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Wed, Sep 04, 2024 at 02:10:28PM -0300, Ranier Vilela wrote:
>> I think that commit 6ebeeae
>> <http://6ebeeae29626e742bbe16db3fa6fccf1186c0dfb> left out an oversight.
>>
>> The report is:
>> CID 1559991: (#1 of 1): Dereference null return value (NULL_RETURNS)
>>
>> The function *findTypeByOid* can return NULL.
>> It is necessary to check the function's return,
>> as is already done in other parts of the source.
>>
>> patch attached.
>
> Yeah, that looks like a problem to me. I've cc'd Daniel here.

Thanks for the report, it does seem genuine to me too. I'll get that handled
later today.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-09-04 18:40:49 Re: Large expressions in indexes can't be stored (non-TOASTable)
Previous Message Tom Lane 2024-09-04 18:34:49 Re: gamma() and lgamma() functions