| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove unused wait events. |
| Date: | 2021-10-25 17:34:37 |
| Message-ID: | 1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
> On 25 Oct 2021, at 19:18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> ... But while I agree it's good to remove unused stuff in the
>> master, it doesn't seem like we really need to back-patch it.
>
> Yeah, exactly. I don't see any benefit that's commensurate with
> even a small risk of breaking extensions --- and apparently, in
> this case that's not a risk but a certainty.
Since this will cause integer values to have different textual enum value
representations in 14 and 15+, do we want to skip two numbers by assigning the
next wait event the integer value of WAIT_EVENT_WAL_WRITE incremented by three?
Or enum integer reuse not something we guarantee against across major versions?
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-10-25 17:39:44 | Re: pgsql: Remove unused wait events. |
| Previous Message | Tom Lane | 2021-10-25 17:18:26 | Re: pgsql: Remove unused wait events. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-10-25 17:39:44 | Re: pgsql: Remove unused wait events. |
| Previous Message | Andres Freund | 2021-10-25 17:29:39 | Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats(). |