Re: PGXS: REGRESS_OPTS=--load-language=plpgsql

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, David Fetter <david(at)fetter(dot)org>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PGXS: REGRESS_OPTS=--load-language=plpgsql
Date: 2010-02-20 19:25:56
Message-ID: 159E10CF-FCF6-458C-8A15-093937050E1C@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Feb 20, 2010, at 11:03 AM, Bruce Momjian wrote:

>> There is also the "must fix" issue with pg_regress.
>
> Why? My pg_regress runs just fine. If you are talking about 3rd party
> modules, I suggested conditional Makefile rules.

Because you can either make the simple change to pg_regress that David Fetter sent yesterday and have things continue to work, or you can break a slew of third-party module test suites (and possibly modules, as well) and make a lot of other people do a lot more work, not to mention email -hackers and ask WTF happened because they may well not know.

I think that not changing pg_regress is more work for third-party module maintainers *and* more work for the Pg community when those maintainers come asking what happened and for advice on how to fix it.

Best,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2010-02-20 19:51:28 Re: PGXS: REGRESS_OPTS=--load-language=plpgsql
Previous Message Bruce Momjian 2010-02-20 19:03:08 Re: PGXS: REGRESS_OPTS=--load-language=plpgsql