Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kevin Grittner <kgrittn(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Inline initial comparisons in TestForOldSnapshot()
Date: 2016-04-21 18:45:16
Message-ID: 15986.1461264316@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Kevin Grittner <kgrittn(at)gmail(dot)com> writes:
> No joy with that shot in the dark.

> Should I add PGDLLEXPORT to the declaration of
> old_snapshot_threshold. That doesn't seem to be documented
> anywhere, or have any useful comments; but it looks like it *might*
> be the arcane incantation needed here.

PGDLLIMPORT is what's needed on any backend global variable that's to
be referenced by extensions. I already pushed a fix before noticing
this thread.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Ants Aasma 2016-04-21 19:10:58 Re: [HACKERS] Re: pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Previous Message Tom Lane 2016-04-21 18:33:39 pgsql: PGDLLIMPORT-ify old_snapshot_threshold.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-04-21 18:52:01 Re: Wire protocol change
Previous Message Robert Haas 2016-04-21 18:25:06 Re: kqueue