| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Complier warnings on mingw gcc 4.5.0 |
| Date: | 2010-12-16 01:46:52 |
| Message-ID: | 15710.1292464012@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 12/15/2010 07:24 PM, Tom Lane wrote:
>> Should we backpatch either of these things?
> Yes. We need it to back at least to 9.0.
On reflection I think we probably better fix it back to 8.2, since we're
supposedly supporting Windows on all those branches, and somebody might
try to build any of them on modern mingw.
> I believe #2 is in fact necessary. When I tried just #1 before it
> failed. What's the best way to do #2 cleanly?
We can't change the meaning of HAVE_INT_OPTRESET because that would
break the declaration logic in getopt.c. I'm thinking we have to
complicate the #if logic in postmaster.c and postgres.c. Will look
into it as soon as I get done with the contrib/seg patch (ie in an
hour or so).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniele Varrazzo | 2010-12-16 01:51:07 | Re: [HACKERS] getting composite types info from libpq |
| Previous Message | Andrew Dunstan | 2010-12-16 00:57:19 | Re: Complier warnings on mingw gcc 4.5.0 |