Re: [HACKERS] win32 crash in initdb

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: "Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com>, pgsql-hackers-win32(at)postgresql(dot)org, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] win32 crash in initdb
Date: 2004-07-29 17:25:19
Message-ID: 15610.1091121919@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Indeed that was the problem. Attached patch fixes the issue here and for
> Merlin :-)

This is not a good patch because it will treat the predictable pre-1970
failure as meaning the TZ should be rejected entirely. What we want to
do is treat a null result as a non-match and score the TZ according to
the number of prior successful matches.

regards, tom lane

In response to

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Magnus Hagander 2004-07-29 17:26:28 Re: localtime() for win32 problem.
Previous Message Merlin Moncure 2004-07-29 17:20:11 Re: [HACKERS] win32 crash in initdb

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-07-29 17:33:35 Re: [HACKERS] Point in Time Recovery
Previous Message Tom Lane 2004-07-29 17:16:05 Re: [HACKERS] Point in Time Recovery