| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb) |
| Date: | 2021-02-12 17:19:43 |
| Message-ID: | 1557041.1613150383@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
I've updated buildfarm member longfin to use "-fsanitize=alignment
-fsanitize-trap=alignment", and it just got through a run successfully
with that. It'd be good perhaps if some other buildfarm owners
followed suit (mumble JIT coverage mumble).
Looking around at other recent reports, it looks like we'll need to tweak
the compiler version cutoffs a bit. I see for instance that spurfowl,
with gcc (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609, is whining:
pg_crc32c_sse42.c:24:1: warning: \342\200\230no_sanitize\342\200\231 attribute directive ignored [-Wattributes]
So maybe it'd better be __GNUC__ >= 6 not __GNUC__ >= 5. I think
we can wait a little bit for more reports before messing with that,
though.
Once this does settle, should we consider back-patching so that it's
possible to run alignment checks in the back branches too?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-02-12 21:27:09 | pgsql: Avoid divide-by-zero in regex_selectivity() with long fixed pref |
| Previous Message | Alexander Korotkov | 2021-02-12 14:29:48 | Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Isaac Morland | 2021-02-12 17:35:55 | Trigger execution role |
| Previous Message | Justin Pryzby | 2021-02-12 17:02:52 | Re: pg13.2: invalid memory alloc request size NNNN |