Re: pgsql: Add TAP tests for pg_verify_checksums

Hi,

Am Freitag, den 19.10.2018, 10:36 -0400 schrieb Stephen Frost:
> Greetings,
>
> * Michael Paquier (michael(at)paquier(dot)xyz) wrote:
> > On Wed, Oct 17, 2018 at 05:30:05PM -0400, Andrew Dunstan wrote:
> > > Fine by me.
> >
> > Thanks. This is now committed after some tweaks to the comments, a bit
> > earlier than I thought first.
>
> I just saw this committed and I'm trying to figure out why we are
> creating yet-another-list when it comes to deciding what should be
> checksum'd and what shouldn't be.
>
> Specifically, pg_basebackup (or, really,
> src/backend/replication/basebackup.c) has 'is_checksummed_file' which
> operates differently from pg_verify_checksum with this change, and that
> seems rather wrong.

To be fair, the list in src/backend/replication/basebackup.c was a copy-
paste from the one in pg_verify_checksums (or from other parts of the
online activation patch).

I agree it makes sense to have both in sync or, better yet, factored out
in a central place, but I don't currently have further opinions on
whether it should be a black- or whitelist.

Michael

--
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax: +49 2166 9901-100
Email: michael(dot)banck(at)credativ(dot)de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer

Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz