| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Date: | 2018-10-19 14:53:09 |
| Message-ID: | 1307.1539960789@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Banck <michael(dot)banck(at)credativ(dot)de> writes:
> Am Freitag, den 19.10.2018, 10:36 -0400 schrieb Stephen Frost:
>> I just saw this committed and I'm trying to figure out why we are
>> creating yet-another-list when it comes to deciding what should be
>> checksum'd and what shouldn't be.
> To be fair, the list in src/backend/replication/basebackup.c was a copy-
> paste from the one in pg_verify_checksums (or from other parts of the
> online activation patch).
Seems like a job for a new(?) module in src/common/.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-10-19 14:57:14 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Previous Message | Michael Banck | 2018-10-19 14:43:29 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-10-19 14:57:14 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Previous Message | Michael Banck | 2018-10-19 14:43:29 | Re: pgsql: Add TAP tests for pg_verify_checksums |