Re: pgsql: Back-patch fix and test case for bug #7516.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Back-patch fix and test case for bug #7516.
Date: 2012-09-14 16:09:36
Message-ID: 15320.1347638976@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 09/14/2012 11:50 AM, Tom Lane wrote:
>> Back-patch the fix to all active branches. The test case only works
>> as far back as 9.0, because it relies on plpgsql which isn't installed
>> by default before that. (I didn't have success modifying it into an
>> all-plperl form that still provoked a crash, though this may just reflect
>> my lack of Perl-fu.)

> I haven't looked at creating a perl version, but why not just load
> plpgsql for the tests on the back branches? It would be a simple
> makefile change.

Yeah, I had considered that for a second or two, but didn't think it was
worth the trouble. 8.x releases are probably unlikely to get installed
on platforms that would have this issue.

It'd be better if someone could invent a plpgsql-free test case, anyway.
I'm not sure offhand why an eval fails to produce similar effects.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-09-14 16:28:05 Re: Re: [COMMITTERS] pgsql: Properly set relpersistence for fake relcache entries.
Previous Message Andrew Dunstan 2012-09-14 16:02:30 Re: pgsql: Back-patch fix and test case for bug #7516.