| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Let's remove DSM_INPL_NONE. |
| Date: | 2018-02-27 19:41:47 |
| Message-ID: | 15255.1519760507@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Feb 15, 2018 at 1:00 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> Hm, I'm not quite convinced by this. Seems to make testing a bunch of
>> codepaths harder. I think it's fine to say that pg doesn't work
>> correctly with them disabled though.
> I'm not sure I understand this. Do you mean we should just add a
> disclaimer to the documentation?
What I didn't understand about it was what kind of testing this'd make
harder. If we desupport dynamic_shared_memory_type=none, there aren't
any code paths that need to cope with the case, and we should just
remove any code that thereby becomes unreachable.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-02-27 19:44:37 | Re: Wait event names mismatch: oldserxid |
| Previous Message | Robert Haas | 2018-02-27 19:39:13 | Re: Registering LWTRANCHE_PARALLEL_HASH_JOIN |