Re: [ADMIN] pg_upgrade from 9.1.3 to 9.2 failed

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Rural Hunter <ruralhunter(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [ADMIN] pg_upgrade from 9.1.3 to 9.2 failed
Date: 2012-09-24 14:38:51
Message-ID: 14856.1348497531@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-admin pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Mon, Sep 24, 2012 at 10:13:45AM -0400, Tom Lane wrote:
>> FWIW, what I found out last time I touched this code is that on many
>> systems setlocale doesn't bother to return a canonicalized spelling;
>> it just gives back the string you gave it. It might be worth doing
>> what Peter suggests, just to be consistent with what we are doing
>> elsewhere, but I'm not sure how much it will help.

> This comment in initdb.c doesn't sound hopeful:

> * If successful, and canonname isn't NULL, a malloc'd copy of the locale's
> * canonical name is stored there. This is especially useful for figuring out
> * what locale name "" means (ie, the environment value). (Actually,
> * it seems that on most implementations that's the only thing it's good for;
> * we could wish that setlocale gave back a canonically spelled version of
> * the locale name, but typically it doesn't.)

Yeah, I wrote that. We can hope that the OP is running on a platform
where setlocale does canonicalize the name, in which case doing the
same thing in pg_upgrade that initdb does would fix his problem. But
I'm not going to predict success.

regards, tom lane

In response to

Browse pgsql-admin by date

  From Date Subject
Next Message Rural Hunter 2012-09-24 14:45:34 Re: [ADMIN] pg_upgrade from 9.1.3 to 9.2 failed
Previous Message Bruce Momjian 2012-09-24 14:31:04 Re: [ADMIN] pg_upgrade from 9.1.3 to 9.2 failed

Browse pgsql-hackers by date

  From Date Subject
Next Message Karl O. Pinc 2012-09-24 14:38:53 Re: Doc patch to note which system catalogs have oids
Previous Message Bruce Momjian 2012-09-24 14:31:04 Re: [ADMIN] pg_upgrade from 9.1.3 to 9.2 failed