From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
Date: | 2017-05-17 18:44:31 |
Message-ID: | 1454.1495046671@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-05-17 13:35:22 -0400, Tom Lane wrote:
>> Not sure about actually incorporating it into our repo. Doing so would
>> make it easier for people to use, for sure, and the license seems to be
>> regular 3-clause BSD, so that angle is OK. But do we want to be carrying
>> around another 150K of source code?
> 150k? Isn't it like 3-4k?
The version we're using now is
$ tar xfz ~/archive/pg_bsd_indent-1.3.tar.gz
$ wc pg_bsd_indent/*
38 122 928 pg_bsd_indent/Makefile
107 831 4835 pg_bsd_indent/README
508 1743 11988 pg_bsd_indent/args.c
569 2727 14732 pg_bsd_indent/indent.1
1288 5677 37815 pg_bsd_indent/indent.c
101 671 4251 pg_bsd_indent/indent_codes.h
367 2376 15206 pg_bsd_indent/indent_globs.h
685 2781 18045 pg_bsd_indent/io.c
634 2709 17017 pg_bsd_indent/lexi.c
306 1133 8019 pg_bsd_indent/netbsd.patch
366 1659 10953 pg_bsd_indent/parse.c
478 2427 15199 pg_bsd_indent/pr_comment.c
5447 24856 158988 total
(Note I was counting bytes not LOC.)
I've not looked at FreeBSD's version, but I'll bet a nickel it's bigger.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2017-05-17 18:50:41 | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
Previous Message | Robert Haas | 2017-05-17 18:42:52 | pgsql: Code review for make_partition_op_expr. |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2017-05-17 18:50:41 | Re: pgindent (was Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.) |
Previous Message | Robert Haas | 2017-05-17 18:43:12 | Re: fix hard-coded index in make_partition_op_expr |