From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bernd Helmle <mailings(at)oopsware(dot)de> |
Cc: | Guillaume Smet <guillaume(dot)smet(at)gmail(dot)com>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Automatic view update rules Bernd Helmle |
Date: | 2009-01-25 16:47:11 |
Message-ID: | 14528.1232902031@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Bernd Helmle <mailings(at)oopsware(dot)de> writes:
> I originally had the idea of a GUC which controls wether automatic rules
> will be generated or not. But I abonded this idea, since this has some kind
> of "parametrized SQL standard functionality".
We have GUCs like that already, for exactly the same reason: backwards
compatibility with prior releases in which some feature didn't work as
per SQL standard. I think the argument that "no existing application
is going to be expecting these auto rules to appear" is pretty strong.
Arguably, pg_dump from an older version should make sure that the auto
rules should NOT get created, else it is failing to preserve an older
view's behavior.
The main question in my mind is whether we should have a turn-off
feature that is global (GUC) or per-view (reloption). One difficulty
with a reloption is that there's no way to set it on a view until after
you've done CREATE VIEW, whereupon it's too late --- the auto rules
are already there, and surely the reloption mechanism isn't going to
know how to make them go away.
This would all be a little easier to accomplish if the behavior were
made to be implicit in the rewriter (ie, rewrite instead of throwing a
"no rule" error), since then there is no persistent state that a GUC or
reloption would have to try to add or get rid of. However, I do rather
like the idea that the auto rules are just a special case of some syntax
with wider usage than the auto rules themselves. So it's a tradeoff.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2009-01-25 17:16:56 | Re: [COMMITTERS] pgsql: Automatic view update rules Bernd Helmle |
Previous Message | Guillaume Smet | 2009-01-25 15:00:05 | Re: [COMMITTERS] pgsql: Automatic view update rules Bernd Helmle |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-01-25 17:06:50 | 8.4 release planning (was Re: [COMMITTERS] pgsql: Automatic view update rules) |
Previous Message | Simon Riggs | 2009-01-25 16:19:33 | Re: Hot standby, conflict resolution |