| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Brendan Jurd" <direvus(at)gmail(dot)com> |
| Cc: | "Simon Riggs" <simon(at)2ndquadrant(dot)com>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] quote_literal with NULL |
| Date: | 2007-10-15 14:28:21 |
| Message-ID: | 14280.1192458501@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
"Brendan Jurd" <direvus(at)gmail(dot)com> writes:
> I'm all for the prevalance of sanity, but I'm not really clear on what
> about the above scenario is not sane.
Well, a situation like that just calls into question whether there's
been a mistake --- in particular whether the underlying function is
really null-safe or not.
We could remove the opr_sanity test, but to me that'd be akin to
disabling a compiler warning. Our project policy has generally been
to write warning-free code, instead.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-10-15 16:18:41 | Re: Windows and locales and UTF-8 (oh my) |
| Previous Message | Magnus Hagander | 2007-10-15 11:40:10 | Re: Windows and locales and UTF-8 (oh my) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-10-16 02:32:47 | Re: Assertion failure with small block sizes |
| Previous Message | Tom Lane | 2007-10-15 14:05:06 | Re: Updated patch for tsearch contrib examples |