Re: Assertion failure with small block sizes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: "PostgreSQL-development Hackers" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Assertion failure with small block sizes
Date: 2007-10-16 02:32:47
Message-ID: 1323.1192501967@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> If I push the TOAST_TUPLES_PER_PAGE up to 16 I get another failure on the same
> line from trying to toast a sequence. If I add RELKIND_SEQUENCE to the
> assertion then it passes all regression tests even if I push
> TOAST_TUPLES_PER_PAGE up to 1024 -- ie, try to toast everything as far as
> possible. Perhaps heapam.c:1761 should just check for RELKIND_SEQUENCE as
> well.

Hmm. I'm inclined to reverse the tests (there are 3 not just 1) in
heapam.c, so that it explicitly tries to toast only in plain tables,
rather than adding more exclusion cases. Thoughts?

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Gregory Stark 2007-10-16 03:38:09 Re: Assertion failure with small block sizes
Previous Message Tom Lane 2007-10-15 14:28:21 Re: [HACKERS] quote_literal with NULL