Re: Minor improvements to test log navigability

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor improvements to test log navigability
Date: 2022-05-16 16:18:24
Message-ID: 1377860.1652717904@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2022-May-16, Thomas Munro wrote:
>> 1. It seems a bit useless to have a load of "FATAL: the database
>> system is in recovery mode" spam whenever the server crashes under
>> src/test/regress. Any reason not to just turn that off, as we do for
>> the TAP tests?

> I don't know of any. Let's.

Have you actually tested what happens? I fear this would just
result in different spam.

>> 2. The TAP test logs are strangely named. Any reason not to call
>> them 001_testname.log, instead of regress_log_001_testname, so they
>> appear next to the corresponding
>> 001_testname_{primary,standby,xxx}.log in directory listings (CI) and
>> dumps (build farm, presumably), and have a traditional .log suffix?

> +1.

Andrew would have to weigh in on whether this'd break the buildfarm,
but if it doesn't, +1.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-05-16 16:21:09 weird comments in Memoize nodes
Previous Message Andres Freund 2022-05-16 16:15:24 Re: [RFC] building postgres with meson -v8