weird comments in Memoize nodes

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: weird comments in Memoize nodes
Date: 2022-05-16 16:21:09
Message-ID: 0635f5aa-4973-8dc2-4e4e-df9fd5778a65@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Consider:

typedef struct Memoize
{
Plan plan;

int numKeys; /* size of the two arrays below */

Oid *hashOperators; /* hash operators for each key */
Oid *collations; /* cache keys */
List *param_exprs; /* exprs containing parameters */
...

I think the comment "cache keys" is weird here. Maybe it was copied from

typedef struct MemoizePath
{
Path path;
Path *subpath; /* outerpath to cache tuples from */
List *hash_operators; /* hash operators for each key */
List *param_exprs; /* cache keys */
...

but it's attached to a different field there.

Is this a mistake, or could this be clarified?

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dan Lynch 2022-05-16 16:32:37 Postgres AST Deparser for Postgres
Previous Message Tom Lane 2022-05-16 16:18:24 Re: Minor improvements to test log navigability