Re: [PATCH] Remove useless USE_PGXS support in contrib

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: cedric(at)2ndquadrant(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, amul sul <sul_amul(at)yahoo(dot)co(dot)in>
Subject: Re: [PATCH] Remove useless USE_PGXS support in contrib
Date: 2013-06-19 02:56:16
Message-ID: 1371610576.13762.24.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 2013-06-16 at 18:20 +0200, Cédric Villemain wrote:
> Also I suggest to remove the need to set REGRESS at all, and default
> to all sql files in REGRESSDIR/sql (if REGRESSDIR is set)

I'm not so sure about that. I have some extensions where the list of
tests is composed at build time depending on the target version (e.g.,
supports extensions, inline, event triggers, etc.). In a different
world, we'd have "skip" functionality for that sort of thing, but for
now building up the list of tests seems best.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-06-19 02:58:15 Re: [PATCH] Remove useless USE_PGXS support in contrib
Previous Message Peter Eisentraut 2013-06-19 02:51:27 Re: [PATCH] Remove useless USE_PGXS support in contrib